boards: add Arduino UNO Q #97118

facchinm · 2025-10-07T13:40:02Z

Uses an STM32U585 microcontroller.
Some drivers will need to be developed (led matrix, internal RPC)

fabiobaltieri · 2025-10-09T05:07:35Z

boards/arduino/uno_q/arduino_uno_q-common.dtsi

+	status = "okay";
+	pinctrl-0 = <&i2c4_scl_pd12 &i2c4_sda_pd13>;
+	pinctrl-1 = <&i2c4_scl_pf14 &i2c4_sda_pf15>;
+	pinctrl-names = "default", "sleep"; /* TODO: sleep is jmisc mux */


may be worth explanding the comment, not very clear at the moment

We have connected the same CPU peripheral to multiple sets of pins and need a solution to choose which pinmux must be applied at runtime; the choice of sleep was just a helpful placeholder.
Converted to regular comments and will submit a separate PR to provide this functionality.

fabiobaltieri · 2025-10-09T05:10:04Z

boards/arduino/uno_q/arduino_uno_q-common.dtsi

+	pinctrl-0 = <&spi2_sck_pb13
+		     &spi2_miso_pb14 &spi2_mosi_pb15 &spi2_nss_pb9>;
+	pinctrl-1 = <&spi2_sck_pd1
+		     &spi2_miso_pc2 &spi2_mosi_pc3>;


nit: that's a weird way to indent this, maybe do two per line? or use #92334 if you feel like trying it, worked well from what I've seen

Tried downloading the latest available dts-linter (0.3.0-beta.5), but it did not flag or correct those. Fixed them by hand 👍

fabiobaltieri · 2025-10-09T05:10:30Z

boards/arduino/uno_q/arduino_uno_q-common.dtsi

+
+&gpiog {
+	status = "okay";
+};


missing eof newline, fix your editor

fabiobaltieri · 2025-10-09T05:13:26Z

boards/arduino/uno_q/board.cmake

+  # Flash merged TF-M + Zephyr binary
+  set_property(TARGET runners_yaml_props_target PROPERTY hex_file tfm_merged.hex)
+
+  if (CONFIG_HAS_FLASH_LOAD_OFFSET)


check the compliance error, this one is very uninsightful for some reasons but I think it's complaining about the space after the if

@rugeGerritsen can you take a look? The error only shows

boards/arduino/uno_q/board.cmake:8 CMakeStyle

fabiobaltieri · 2025-10-09T05:15:45Z

boards/arduino/uno_q/doc/img/arduino_uno_q.webp

this has to be under 100k or somehing, crop the whitespace and pass it through https://tinywebp.app/ or something

fabiobaltieri · 2025-10-09T05:16:24Z

boards/arduino/uno_q/doc/index.rst

+
+.. code-block:: console
+
+   adb forward tcp:3333 tcp:3333 && adb shell arduino-debug


fancy, I presume this has to be run from the application processor? May be worth expanding a bit on it, or maybe just like the official programming documentation

nashif · 2025-10-09T09:46:08Z

I wonder what the "Q" stands for

pillo79

Thanks @fabiobaltieri for the review, comments should be addressed.

pillo79 · 2025-10-09T13:33:19Z

boards/arduino/uno_q/arduino_uno_q-common.dtsi

+	pinctrl-0 = <&spi2_sck_pb13
+		     &spi2_miso_pb14 &spi2_mosi_pb15 &spi2_nss_pb9>;
+	pinctrl-1 = <&spi2_sck_pd1
+		     &spi2_miso_pc2 &spi2_mosi_pc3>;


Tried downloading the latest available dts-linter (0.3.0-beta.5), but it did not flag or correct those. Fixed them by hand 👍

pillo79 · 2025-10-09T14:13:18Z

boards/arduino/uno_q/arduino_uno_q-common.dtsi

+	status = "okay";
+	pinctrl-0 = <&i2c4_scl_pd12 &i2c4_sda_pd13>;
+	pinctrl-1 = <&i2c4_scl_pf14 &i2c4_sda_pf15>;
+	pinctrl-names = "default", "sleep"; /* TODO: sleep is jmisc mux */


We have connected the same CPU peripheral to multiple sets of pins and need a solution to choose which pinmux must be applied at runtime; the choice of sleep was just a helpful placeholder.
Converted to regular comments and will submit a separate PR to provide this functionality.

pillo79 · 2025-10-09T14:21:11Z

Sorry for the noise, did a pretty bad rebase 👎

Uses an STM32U585 microcontroller. Some drivers will need to be developed (led matrix, internal RPC) Signed-off-by: Martino Facchin <[email protected]> Signed-off-by: Luca Burelli <[email protected]>

sonarqubecloud · 2025-10-09T14:43:05Z

Please retry analysis of this Pull-Request directly on SonarQube Cloud

kylebonnici · 2025-10-09T14:52:49Z

I can confirm the the current sha 94c74f9 produced the right formatting

uno_q % dts-linter --formatFixAll                                                                        
✅  Searching for '**/*.{dts,dtsi,overlay}' in /Users/kylebonnici/workspace/personal/zephyr/boards/arduino/uno_q
✅ [1/4] arduino_uno_q_stm32u585xx_ns.dts is correctly formatted
✅ [2/4] arduino_uno_q.dts is correctly formatted
✅ [3/4] arduino_uno_q-common.dtsi is correctly formatted
✅ [4/4] arduino_r3_connector.dtsi is correctly formatted
✅  Processed 4 files
✅  All files passed formatting

@pillo79

Tried downloading the latest available dts-linter (0.3.0-beta.5), but it did not flag or correct those. Fixed them by hand 👍

I have tried the linter on c080801 and I got the diff see attached, can you share how you ran it so I can fix any issues present.

diff.patch

pillo79 · 2025-10-09T15:45:17Z

I have tried the linter on c080801 and I got the diff see attached, can you share how you ran it so I can fix any issues present.

diff.patch

Thanks for confirming! Then there is no issue. I guess we were both surprised that the lines Fabio highlighted :

zephyr/boards/arduino/uno_q/arduino_uno_q-common.dtsi

Lines 133 to 136 in c080801

    
           pinctrl-0 = <&spi2_sck_pb13 
        
           	     &spi2_miso_pb14 &spi2_mosi_pb15 &spi2_nss_pb9>; 
        
           pinctrl-1 = <&spi2_sck_pd1 
        
           	     &spi2_miso_pc2 &spi2_mosi_pc3>;

did not trigger any rewrite even if they definitely look ugly, but you confirmed they don't breach any existing rules.

Also, I'm not sure we want to enforce a reformat for those: it will be a pretty invasive change whatever direction is chosen (one per line, reflow to some width etc).

kylebonnici · 2025-10-09T15:59:05Z

I have tried the linter on c080801 and I got the diff see attached, can you share how you ran it so I can fix any issues present.
diff.patch

Thanks for confirming! Then there is no issue. I guess we were both surprised that the lines Fabio highlighted :

zephyr/boards/arduino/uno_q/arduino_uno_q-common.dtsi

Lines 133 to 136 in c080801

pinctrl-0 = <&spi2_sck_pb13

&spi2_miso_pb14 &spi2_mosi_pb15 &spi2_nss_pb9>;

pinctrl-1 = <&spi2_sck_pd1

&spi2_miso_pc2 &spi2_mosi_pc3>;

did not trigger any rewrite even if they definitely look ugly, but you confirmed they don't breach any existing rules.

Also, I'm not sure we want to enforce a reformat for those: it will be a pretty invasive change whatever direction is chosen (one per line, reflow to some width etc).

No there are no such rules in place at the moment. The only rules I am planning to add in the near future is to reflow when we exceed 100 char and only if we can physically split the line.

nordicjm · 2025-10-10T07:46:28Z

boards/arduino/uno_q/arduino_uno_q.dts

+		scratch_partition: partition@e0000 {
+			label = "image-scratch";
+			reg = <0x000e0000 DT_SIZE_K(64)>;
+		};


not a change request but swap using scratch should only be used if you have different sector sizes in one slot or between both slots

nordicjm · 2025-10-10T07:46:47Z

boards/arduino/uno_q/arduino_uno_q_defconfig

@@ -0,0 +1,11 @@
+# SPDX-License-Identifier: Apache-2.0
+
+# enable uart driver


capitalise first letters of comments and acronyms like UART

nordicjm · 2025-10-10T07:47:42Z

boards/arduino/uno_q/doc/img/arduino_uno_q.webp

please reduce resolution of image

facchinm requested a review from kartben October 7, 2025 13:40

zephyrbot added the area: Boards/SoCs label Oct 7, 2025

zephyrbot requested a review from pillo79 October 7, 2025 13:41

zephyrbot assigned pillo79 Oct 7, 2025

fabiobaltieri requested a review from nordicjm October 9, 2025 05:06

fabiobaltieri reviewed Oct 9, 2025

View reviewed changes

pillo79 force-pushed the unoq-pr branch from c080801 to e9bb3d6 Compare October 9, 2025 14:15

pillo79 reviewed Oct 9, 2025

View reviewed changes

zephyrbot requested review from KhiemNguyenT, danieldegrasse, de-nordic, decsny, duynguyenxa, jfischer-no, khoa-nguyen-18, rghaddab, soburi, thaoluonguw and thenguyenyf October 9, 2025 14:17

pillo79 force-pushed the unoq-pr branch from e9bb3d6 to f06281e Compare October 9, 2025 14:20

zephyrbot requested a review from pillo79 October 9, 2025 14:21

boards: add Arduino UNO Q

94c74f9

Uses an STM32U585 microcontroller. Some drivers will need to be developed (led matrix, internal RPC) Signed-off-by: Martino Facchin <[email protected]> Signed-off-by: Luca Burelli <[email protected]>

pillo79 force-pushed the unoq-pr branch from f06281e to 94c74f9 Compare October 9, 2025 14:26

thenguyenyf removed their request for review October 10, 2025 03:15

nordicjm requested changes Oct 10, 2025

View reviewed changes


		.. code-block:: console

		adb forward tcp:3333 tcp:3333 && adb shell arduino-debug

		@@ -0,0 +1,11 @@
		# SPDX-License-Identifier: Apache-2.0

		# enable uart driver

boards: add Arduino UNO Q #97118

Are you sure you want to change the base?

boards: add Arduino UNO Q #97118

Uh oh!

Conversation

facchinm commented Oct 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nashif commented Oct 9, 2025

Uh oh!

pillo79 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pillo79 commented Oct 9, 2025

Uh oh!

sonarqubecloud bot commented Oct 9, 2025

Uh oh!

kylebonnici commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pillo79 commented Oct 9, 2025

Uh oh!

kylebonnici commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kylebonnici commented Oct 9, 2025 •

edited

Loading

kylebonnici commented Oct 9, 2025 •

edited

Loading